On Thu, 02 Oct 2025, Michał Grzelak <[email protected]> wrote: > On Thu, 2 Oct 2025, Jani Nikula wrote: >> Separating the panic allocation from framebuffer allocation in commit >> 729c5f7ffa83 ("drm/{i915,xe}/panic: move framebuffer allocation where it >> belongs") failed to deallocate the panic structure anywhere. >> >> The fix is two-fold. First, free the panic structure in >> intel_user_framebuffer_destroy() in the general case. Second, move the >> panic allocation later to intel_framebuffer_init() to not leak the panic >> structure in error paths (if any, now or later) between >> intel_framebuffer_alloc() and intel_framebuffer_init(). >> >> Fixes: 729c5f7ffa83 ("drm/{i915,xe}/panic: move framebuffer allocation where >> it belongs") >> Cc: Jocelyn Falempe <[email protected]> >> Cc: Maarten Lankhorst <[email protected]> >> Reported-by: Michał Grzelak <[email protected]> >> Suggested-by: Ville Syrjälä <[email protected]> >> Signed-off-by: Jani Nikula <[email protected]> > > Have run a bunch of tests on affected platform, which previously caused > the issue to surface. With the patch applied no memleaks are reported. > > Tested-by: Michał Grzelak <[email protected]>
Thanks for confirming! Looks like we'll need to merge [1] first, or the stable backport of that is going to be a nightmare. BR, Jani. [1] https://lore.kernel.org/r/[email protected] -- Jani Nikula, Intel
