On Thu, 09 Oct 2025, Matt Atwood <[email protected]> wrote: > reg_in_range_table is a useful function that is used in multiple places, > and will be needed for WA_BB implementation later. > > Let's move this function and i915_range struct to its own file, as we are > trying to move away from i915_utils files. > > v2: move functions to their own file > v3: use correct naming convention
Okay, Message from the Department of Bikeshedding and Nitpicking. There's really nothing mmio specific about the functionality being abstracted. You have a range represented by two u32's in a struct, and a function to check if another u32 is within that range. The struct could just as well remain i915_range, the files could be i915_range.[ch], and the function could be, say, i915_range_table_contains(). IMO "mmio" makes it unnecessarily specific. > +bool i915_mmio_range_table_contains(u32 addr, const struct i915_mmio_range > *table) Usually, the "context" parameter goes first. I get that this wasn't the case before, but I'd use the opportunity to swap these around. BR, Jani. -- Jani Nikula, Intel
