On Wed, 22 Oct 2025, Jouni Högander <[email protected]> wrote: > From: Jani Nikula <[email protected]> > > Let's gradually start calling i915 and xe parent, or core, drivers from > display via function pointers passed at display probe. > > Going forward, the struct intel_display_parent_interface is expected to > include const pointers to sub-structs by functionality, for example: > > struct intel_display_rpm { > struct ref_tracker *(*get)(struct drm_device *drm); > /* ... */ > }; > > struct intel_display_parent_interface { > /* ... */ > const struct intel_display_rpm *rpm; > }; > > This is a baby step towards not building display as part of both i915 > and xe drivers, but rather making it an independent driver interfacing > with the two. > > Cc: Jouni Högander <[email protected]> > Cc: Lucas De Marchi <[email protected]> > Cc: Rodrigo Vivi <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Signed-off-by: Jani Nikula <[email protected]>
You do need you add your own Signed-off-by even when sending someone else's patches unmodified. > diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > index 7c657ea98a441..3e79a74ff7def 100644 > --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > @@ -12,7 +12,6 @@ > > #include <drm/drm_drv.h> > > -#include "xe_device.h" /* for xe_device_has_flat_ccs() */ > #include "xe_device_types.h" > This hunk doesn't belong here, it's my rebase fail. BR, Jani. -- Jani Nikula, Intel
