On 10/21/2025 12:20 AM, Ville Syrjala wrote:
From: Ville Syrjälä <[email protected]>

Unify the VRR timing computation stuff a bit having both the
fixed refrehs rate and CMRR cases assign the crtc_state->vrr

Nitpick: typo refresh.

Otherwise LGTM.

Reviewed-by: Ankit Nautiyal <[email protected]>

stuff in exactly the same way.

Signed-off-by: Ville Syrjälä <[email protected]>
---
  drivers/gpu/drm/i915/display/intel_vrr.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c 
b/drivers/gpu/drm/i915/display/intel_vrr.c
index 92fb72b56f16..510dc199376f 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -305,12 +305,10 @@ void intel_vrr_set_fixed_rr_timings(const struct 
intel_crtc_state *crtc_state)
  static
  void intel_vrr_compute_fixed_rr_timings(struct intel_crtc_state *crtc_state)
  {
-       /*
-        * For fixed rr,  vmin = vmax = flipline.
-        * vmin is already set to crtc_vtotal set vmax and flipline the same.
-        */
+       /* For fixed rr,  vmin = vmax = flipline */
        crtc_state->vrr.vmax = crtc_state->hw.adjusted_mode.crtc_vtotal;
-       crtc_state->vrr.flipline = crtc_state->hw.adjusted_mode.crtc_vtotal;
+       crtc_state->vrr.vmin = crtc_state->vrr.vmax;
+       crtc_state->vrr.flipline = crtc_state->vrr.vmin;
  }
static

Reply via email to