Quoting Matt Roper (2025-10-22 11:56:40-03:00) >On Tue, Oct 21, 2025 at 09:28:30PM -0300, Gustavo Sousa wrote: >> From: Matt Atwood <[email protected]> >> >> Bandwidth parameters for Xe3p_LPD are the same as for Xe3_LPD. Re-use >> them. >> >> v2: >> - Do not have a special case for ecc_impacting_de_bw, since there are >> no specific instructions in Bspec for this scenario. (Matt Roper) >> >> Bspec: 68859 >> Cc: Matt Roper <[email protected]> >> Signed-off-by: Matt Atwood <[email protected]> >> Signed-off-by: Gustavo Sousa <[email protected]> >> --- >> drivers/gpu/drm/i915/display/intel_bw.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c >> b/drivers/gpu/drm/i915/display/intel_bw.c >> index 57d65e6e5429..57cb8a23188f 100644 >> --- a/drivers/gpu/drm/i915/display/intel_bw.c >> +++ b/drivers/gpu/drm/i915/display/intel_bw.c >> @@ -810,7 +810,9 @@ void intel_bw_init_hw(struct intel_display *display) >> */ >> drm_WARN_ON_ONCE(display->drm, dram_info->ecc_impacting_de_bw); >> >> - if (DISPLAY_VERx100(display) >= 3002) { >> + if (DISPLAY_VER(display) >= 35) { >> + tgl_get_bw_info(display, dram_info, &xe3lpd_sa_info); >> + } else if (DISPLAY_VERx100(display) >= 3002) { > >We could change 30.02 to a "==" since it's a one-off special case, and >let everything else continue to fall into to the ">= 30" branch below.
Yeah, that sounds good. I'll go with your suggestion. >Up to you; either way, > >Reviewed-by: Matt Roper <[email protected]> Thanks! -- Gustavo Sousa > >As I mentioned before, we probably should think about moving the >bandwidth / memory stuff back to being platform-based rather than >IP-based, but that's something we can look at as a folow-up; it doesn't >need to be part of this series. > > >Matt > >> tgl_get_bw_info(display, dram_info, &xe3lpd_3002_sa_info); >> } else if (DISPLAY_VER(display) >= 30) { >> tgl_get_bw_info(display, dram_info, &xe3lpd_sa_info); >> >> -- >> 2.51.0 >> > >-- >Matt Roper >Graphics Software Engineer >Linux GPU Platform Enablement >Intel Corporation
