Quoting Matt Roper (2025-11-03 14:42:23-03:00) >On Mon, Nov 03, 2025 at 02:18:18PM -0300, Gustavo Sousa wrote: >> NVL uses the Lake Tahoe PHY for display output and the driver recently >> added the macro HAS_LT_PHY() to allow selecting code paths specific for >> that type of PHY. >> >> While NVL uses Xe3p_LPD as display IP, the type of PHY is actually >> defined at the SoC level, so use a platform check instead of display >> version. >> >> Bspec: 74199 >> Cc: Suraj Kandpal <[email protected]> >> Cc: Matt Roper <[email protected]> >> Signed-off-by: Gustavo Sousa <[email protected]> > >Eventually we might need to make this a true feature flag, but this
Agreed. >works for now. > >Reviewed-by: Matt Roper <[email protected]> Thanks! -- Gustavo Sousa > >> --- >> drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy.h >> b/drivers/gpu/drm/i915/display/intel_lt_phy.h >> index a538d4c69210..034c20c66baf 100644 >> --- a/drivers/gpu/drm/i915/display/intel_lt_phy.h >> +++ b/drivers/gpu/drm/i915/display/intel_lt_phy.h >> @@ -39,6 +39,6 @@ void intel_xe3plpd_pll_enable(struct intel_encoder >> *encoder, >> const struct intel_crtc_state *crtc_state); >> void intel_xe3plpd_pll_disable(struct intel_encoder *encoder); >> >> -#define HAS_LT_PHY(display) (DISPLAY_VER(display) >= 35) >> +#define HAS_LT_PHY(display) ((display)->platform.novalake) >> >> #endif /* __INTEL_LT_PHY_H__ */ >> >> -- >> 2.51.0 >> > >-- >Matt Roper >Graphics Software Engineer >Linux GPU Platform Enablement >Intel Corporation
