Hi Janusz, [...]
> > > /* Reap exit status of the lmem process */ > > > - igt_waitchildren(); > > > + lmem_err = __igt_waitchildren(); > > By changing igt_waitchildren() to __igt_waitchildren() you > > wanted to outline that this test is not supposed to run on multi > > GPU systems? > > No, my intention was to avoid potential longjmp from inside > igt_waitchildren()->igt_fail() if the lmem eviction process returns a > failure, > so we are still able to signal completion to the smem helpers as below. Once > cleaned up, we are then free to fail on lmem_err. Oh, okay. Maybe it would be good to mention that in a comment? In any case, I think the change is good, so after you address my previous suggestions: Reviewed-by: Krzysztof Karas <[email protected]> -- Best Regards, Krzysztof
