> Subject: [PATCH v2 16/32] drm/i915/cx0: Add PLL information for MTL+
> 
> Start bringing MTL+ platforms as part of PLL framework.
> The work is started by adding PLL information and related function hooks.

Reframe like so
"Bring MTL+ platforms as part of PLL framework.
To do this add PLL information and related function hooks"

Commit messages need to be more like commands.

> 
> BSpec: 55726

Needs to be a trailer right above Signed-off-by
With that fixed
Reviewed-by: Suraj Kandpal <[email protected]>

> 
> v2: Revise commit message and add BSpec ID (Suraj)
> 
> Signed-off-by: Mika Kahola <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 8c345e1bdd94..23f22c495ec7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -4305,6 +4305,25 @@ static const struct intel_dpll_mgr adlp_pll_mgr = {
>       .compare_hw_state = icl_compare_hw_state,  };
> 
> +static const struct intel_dpll_funcs mtl_pll_funcs = { };
> +
> +static const struct dpll_info mtl_plls[] = {
> +     { .name = "DPLL 0", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_DPLL0, },
> +     { .name = "DPLL 1", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_DPLL1, },
> +     /* TODO: Add TBT PLL */
> +     { .name = "TC PLL 1", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_MGPLL1,
> },
> +     { .name = "TC PLL 2", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_MGPLL2,
> },
> +     { .name = "TC PLL 3", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_MGPLL3,
> },
> +     { .name = "TC PLL 4", .funcs = &mtl_pll_funcs, .id = DPLL_ID_ICL_MGPLL4,
> },
> +     {}
> +};
> +
> +__maybe_unused
> +static const struct intel_dpll_mgr mtl_pll_mgr = {
> +     .dpll_info = mtl_plls,
> +};
> +
>  /**
>   * intel_dpll_init - Initialize DPLLs
>   * @display: intel_display device
> --
> 2.34.1

Reply via email to