Re: [PATCH] fixeup! drm/xe/xe_pagefault: Fix potential uninitialized fence usage in xe_pagefault_handle_vma

[Andi Shyti]

Hi Nareshkumar,

On Tue, Nov 25, 2025 at 03:48:42PM +0530, Nareshkumar Gollakoti wrote:
> The variable "fence" should be initialized to NULL,
> and any usage of fence should be guarded
> by a check to ensure it is not NULL
> 
> Signed-off-by: Nareshkumar Gollakoti <naresh.kuma...@intel.com>

is this a fix?

...

> @@ -122,8 +122,10 @@ static int xe_pagefault_handle_vma(struct xe_gt *gt, 
> struct xe_vma *vma,
>               }
>       }
>  
> -     dma_fence_wait(fence, false);
> -     dma_fence_put(fence);
> +     if (fence) {
> +             dma_fence_wait(fence, false);
> +             dma_fence_put(fence);
> +     }

have you seen a case where fence is NULL at this point?

Thanks,
Andi