> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Gustavo
> Sousa
> Sent: Wednesday, December 17, 2025 2:42 AM
> To: [email protected]; [email protected]
> Cc: Sousa, Gustavo <[email protected]>
> Subject: [PATCH 1/2] drm/i915/cx0: Use a more accurate message for
> powerdown change failure
> 
> We do not use the function intel_cx0_powerdown_change_sequence()
> exclusively to take the PHY out of reset, hence the warning message on failure
> is misleading.  Furthermore, in an upcoming change, we will also use that
> function to implement a new C10 PHY workaround.
> 
> Use a more accurate message by saying that we failed to change the
> powerdown state.
> 
> Signed-off-by: Gustavo Sousa <[email protected]>

LGTM,
Reviewed-by: Dnyaneshwar Bhadane <[email protected]>

Dnyaneshwar,
> ---
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index f6d69627154e..264f8a5072e5 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -3059,7 +3059,7 @@ void
> intel_cx0_powerdown_change_sequence(struct intel_encoder *encoder,
> 
> intel_cx0_get_powerdown_update(lane_mask),
> 
> XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS))
>               drm_warn(display->drm,
> -                      "PHY %c failed to bring out of lane reset\n",
> +                      "PHY %c failed to change powerdown state\n",
>                        phy_name(phy));
>  }
> 
> 
> --
> 2.52.0

Reply via email to