On Mon, 2026-01-05 at 14:49 -0300, Gustavo Sousa wrote:
> Quoting Gustavo Sousa (2026-01-05 14:44:39-03:00)
> > Quoting Vinod Govindapillai (2026-01-05 07:48:58-03:00)
> > > For DG2, wa_22014263786 is applicable only if the number of
> > > active
> > > planes is greater than 1 in pipe A and pipe B. Cursor planes and
> > > any planes on pipe C or pipe D are not considered for this. As
> > > for
> > > DG2 this wa condition is based on the number of active planes,
> > > the
> > > check is moved to the fbc post plane update calls. The force slb
> > > invalidation chicken bit is set/unset based on the condition. For
> > > the other platforms where this wa is valid, the wa applied before
> > > enabling the FBC Unconditionally as before.
> > > 
> > > v2: wrong version send as the initial patchset
> > >    for DG2, active planes check should be done all pipes not just
> > >    the FBC pipe  (Matt)
> > > 
> > > Bspec: 54077, 72197
> > > Signed-off-by: Vinod Govindapillai
> > > <[email protected]>
> 
> Ah, also, the commit subject is a bit vague. I would mention "DG2" in
> it
> to make it clear it is about an update specific for DG2.
> 
> Is this an update or rather a fix? In the case of the latter, I guess
> a
> "Fixes:" trailer would also be warranted.

yeah. I was considering that as well! But as this was DG2 specific
update to the wa, thought of sticking with the update.

BR
Vinod
 
> 
> --
> Gustavo Sousa

Reply via email to