Re: [PATCH v6 3/5] drm/xe: Move struct xe_ggtt to xe_ggtt.c

[Michal Wajdeczko]

On 1/26/2026 11:46 AM, Maarten Lankhorst wrote:
> From: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> 
> No users left outside of xe_ggtt.c, so we can make the struct private.
> 
> This prevents us from accidentally touching it before init.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> Reviewed-by: Matthew Brost <matthew.br...@intel.com>
> Signed-off-by: Maarten Lankhorst <d...@lankhorst.se>

still double s-o-b, but code is fine,

Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com>

> ---

...

>  
>  typedef void (*xe_ggtt_set_pte_fn)(struct xe_ggtt *ggtt, u64 addr, u64 pte);
>  typedef void (*xe_ggtt_transform_cb)(struct xe_ggtt *ggtt,
>                                    struct xe_ggtt_node *node,
>                                    u64 pte_flags,
>                                    xe_ggtt_set_pte_fn set_pte, void *arg);

nit: I hope one day we can get rid of these typedefs...