> On 6 Feb 2026, at 14:27, Danilo Krummrich <[email protected]> wrote: > > On Fri Feb 6, 2026 at 6:20 PM CET, Gary Guo wrote: >> I asked for this to be changed to `pub(crate)` because I think this isn't >> something that should be used by drivers. >> >> As you said, tt might be tricky to enforce that with new build system when >> subsystems are inside different crates. But until then I think it's better to >> limit visibility. > > It should *usually* not be used by drivers, but there are exceptions. For > instance, it is perfectly valid to be used by Rust drivers that interact with > C > drivers. I agree with what Danilo said here. I don’t see a reason to forbid drivers from using this. If the reason is the unsafe bits, then isn’t it the same pattern used by impl_has_work!() anyways? i.e.: a macro that implements an unsafe trait so long as the driver gives it the right Work field. Seems equivalent in spirit to the clist_create macro introduced by this patch. — Daniel
- [PATCH -next v7 0/2] rust: Add CList and GPU buddy alloca... Joel Fernandes
- [PATCH -next v7 2/2] rust: gpu: Add GPU buddy alloca... Joel Fernandes
- [PATCH -next v7 1/2] rust: clist: Add support to int... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clist: Add suppor... Gary Guo
- Re: [PATCH -next v7 1/2] rust: clist: Add su... Danilo Krummrich
- Re: [PATCH -next v7 1/2] rust: clist: Ad... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clis... Gary Guo
- Re: [PATCH -next v7 1/2] rust: ... Danilo Krummrich
- Re: [PATCH -next v7 1/2] ru... Gary Guo
- Re: [PATCH -next v7 1/2] ru... Danilo Krummrich
- Re: [PATCH -next v7 1/2] ru... Daniel Almeida
- Re: [PATCH -next v7 1/2] ru... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clist: Add suppor... Daniel Almeida
- Re: [PATCH -next v7 1/2] rust: clist: Add su... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clist: Ad... Gary Guo
- Re: [PATCH -next v7 1/2] rust: clis... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clist: Add su... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: clist: Ad... Daniel Almeida
- Re: [PATCH -next v7 1/2] rust: clis... Joel Fernandes
- Re: [PATCH -next v7 1/2] rust: ... Daniel Almeida
- ✗ Fi.CI.BUILD: failure for rust: Add CList and GPU b... Patchwork
