> -----Original Message-----
> From: Intel-gfx <[email protected]> On Behalf Of Suraj
> Kandpal
> Sent: Friday, February 20, 2026 10:32 AM
> To: [email protected]; [email protected]
> Cc: Nautiyal, Ankit K <[email protected]>; Murthy, Arun R
> <[email protected]>; Kandpal, Suraj <[email protected]>
> Subject: [PATCH 6/8] drm/i915/backlight: Update debug log during backlight
> setup
>
> With luminance_set which represents PANEL_LUMINANCE_OVERRIDE, we
> have another variable other than aux_enable to decide if we use PWM or
> DPCD. Make drm_dbg_kms log represent that.
>
Hi Suraj,
In this patch we have existing parameter aux_enable and you are adding
luminance_set
as new parameter in the log so I guess commit message can be something like
this:
Since luminance_set (PANEL_LUMINANCE_OVERRIDE) will also affect the brightness
control path,
so log this as well along with aux_enable in drm_dbg_kms logs.
Thanks and Regards,
Nemesa
> Signed-off-by: Suraj Kandpal <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index c7143869bafd..043c9aef2ea6 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -539,7 +539,8 @@ static int intel_dp_aux_vesa_setup_backlight(struct
> intel_connector *connector,
> drm_dbg_kms(display->drm,
> "[CONNECTOR:%d:%s] AUX VESA backlight enable is
> controlled through %s\n",
> connector->base.base.id, connector->base.name,
> - dpcd_vs_pwm_str(panel-
> >backlight.edp.vesa.info.aux_enable));
> + dpcd_vs_pwm_str(panel-
> >backlight.edp.vesa.info.aux_enable ||
> + panel-
> >backlight.edp.vesa.info.luminance_set));
> drm_dbg_kms(display->drm,
> "[CONNECTOR:%d:%s] AUX VESA backlight level is
> controlled through %s\n",
> connector->base.base.id, connector->base.name,
> --
> 2.34.1
