> -----Original Message-----
> From: Kandpal, Suraj <[email protected]>
> Sent: Friday, 20 February 2026 4.45
> To: Kahola, Mika <[email protected]>; [email protected];
> [email protected]
> Cc: Kahola, Mika <[email protected]>
> Subject: RE: [PATCH 16/19] drm/i915/lt_phy: Get encoder configuration for
> xe3plpd platform
>
> > Subject: [PATCH 16/19] drm/i915/lt_phy: Get encoder configuration for
> > xe3plpd platform
> >
> > For DDI initialization get encoder configuration by reusing
> > MTL+ configuration.
> >
> > Signed-off-by: Mika Kahola <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_ddi.c | 20 ++++----------------
> > 1 file changed, 4 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> > b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index 532d7d4e3b27..9f3c8cd02a33 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -4244,21 +4244,6 @@ void intel_ddi_get_clock(struct intel_encoder
> > *encoder,
> > &crtc_state-
> > >dpll_hw_state); }
> >
> > -static void xe3plpd_ddi_get_config(struct intel_encoder *encoder,
> > - struct intel_crtc_state *crtc_state)
> > -{
> > - struct intel_display *display = to_intel_display(encoder);
> > -
> > - intel_lt_phy_pll_readout_hw_state(encoder, &crtc_state-
> > >dpll_hw_state.ltpll);
> > -
> > - if (crtc_state->dpll_hw_state.ltpll.tbt_mode)
> > - crtc_state->port_clock =
> > intel_mtl_tbt_calc_port_clock(encoder);
> > - else
> > - crtc_state->port_clock =
> > - intel_lt_phy_calc_port_clock(display, &crtc_state-
> > >dpll_hw_state.ltpll);
> > - intel_ddi_get_config(encoder, crtc_state);
> > -}
> > -
> > static bool icl_ddi_tc_pll_is_tbt(const struct intel_dpll *pll) {
> > return pll->info->id == DPLL_ID_ICL_TBTPLL; @@ -5302,7 +5287,10 @@
> > void intel_ddi_init(struct intel_display *display,
> > encoder->enable_clock = intel_xe3plpd_pll_enable_clock;
> > encoder->disable_clock = intel_xe3plpd_pll_disable_clock;
> > encoder->port_pll_type = intel_mtl_port_pll_type;
> > - encoder->get_config = xe3plpd_ddi_get_config;
> > + if (intel_encoder_is_tc(encoder))
> > + encoder->get_config = mtl_ddi_tc_phy_get_config;
> > + else
> > + encoder->get_config =
> > mtl_ddi_non_tc_phy_get_config;
>
> Lets have a patch which basically does all these hookup assignments
> (enable_clock/ disable_clock/pll_enable/pll_disable etc) in
> one patch let the other functions define the functions that need to be hooked.
> So all these hooks are assigned in one shot and then another removing legacy
> stuff like above in later patch.
>
Ok, so let's modify this patch series so that all these hooks are set in one
patch and all functions that are needed to support this are defined in separate
patch.
Thanks,
Mika
> Regards,
> Suraj Kandpal
>
> > } else if (DISPLAY_VER(display) >= 14) {
> > encoder->enable_clock = intel_mtl_pll_enable_clock;
> > encoder->disable_clock = intel_mtl_pll_disable_clock;
> > --
> > 2.43.0
