On Sun, 08 Mar 2026, Michał Grzelak <[email protected]> wrote: > Check if port_clock is above HBR2 inside separate function.
Same as the previous patch. > > Signed-off-by: Michał Grzelak <[email protected]> > --- > .../drm/i915/display/intel_ddi_buf_trans.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > index ee6a78a20dac..8b369535189c 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > @@ -1191,6 +1191,13 @@ static bool intel_dp_above_hbr1(const struct > intel_crtc_state *crtc_state) > return false; > } > > +static bool intel_edp_above_hbr2(const struct intel_crtc_state *crtc_state) This doesn't have anything to do with "edp" specifically. > +{ > + if (crtc_state->port_clock > 540000) > + return true; > + return false; Side note, this is just "return crtc_state->port_clock > 540000" directly, if-else for returning true/false is unnecessary. BR, Jani. > +} > + > static bool use_edp_hobl(struct intel_encoder *encoder) > { > struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > @@ -1374,7 +1381,7 @@ icl_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) { > + if (intel_edp_above_hbr2(crtc_state)) { > return > intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > } else if (use_edp_low_vswing(encoder)) { > @@ -1499,7 +1506,7 @@ tgl_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) { > + if (intel_edp_above_hbr2(crtc_state)) { > return > intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > } else if (use_edp_hobl(encoder)) { > @@ -1544,7 +1551,7 @@ dg1_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) > + if (intel_edp_above_hbr2(crtc_state)) > return > intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > else if (use_edp_hobl(encoder)) > @@ -1586,7 +1593,7 @@ rkl_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) { > + if (intel_edp_above_hbr2(crtc_state)) { > return > intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > } else if (use_edp_hobl(encoder)) { > @@ -1629,7 +1636,7 @@ adls_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) > + if (intel_edp_above_hbr2(crtc_state)) > return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr3, > n_entries); > else if (use_edp_hobl(encoder)) > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, > n_entries); > @@ -1668,7 +1675,7 @@ adlp_get_combo_buf_trans_edp(struct intel_encoder > *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - if (crtc_state->port_clock > 540000) { > + if (intel_edp_above_hbr2(crtc_state)) { > return intel_get_buf_trans(&adlp_combo_phy_trans_edp_hbr3, > n_entries); > } else if (use_edp_hobl(encoder)) { -- Jani Nikula, Intel
