> Subject: [PATCH 1/2] drm/i915/psr: Disable PSR on update_m_n and update_lrr
> 
> PSR/PR parameters might be changing on update_m_n or update_lrr. Disable

Nit: *might change based on update_m_n or update_lrr

Otherwise LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> on update_m_n and update_lrr to ensure proper parameters are taken into use
> on next PSR enable in intel_psr_post_plane_update.
> 
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15771
> Fixes: 2bc98c6f97af ("drm/i915/alpm: Compute ALPM parameters into
> crtc_state->alpm_state")
> Cc: <[email protected]> # v6.19+
> Signed-off-by: Jouni Högander <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 5041a5a138d1..7e0e4c3bf985 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -3112,6 +3112,8 @@ void intel_psr_pre_plane_update(struct
> intel_atomic_state *state,
>                        * - Display WA #1136: skl, bxt
>                        */
>                       if (intel_crtc_needs_modeset(new_crtc_state) ||
> +                         new_crtc_state->update_m_n ||
> +                         new_crtc_state->update_lrr ||
>                           !new_crtc_state->has_psr ||
>                           !new_crtc_state->active_planes ||
>                           new_crtc_state->has_sel_update != psr-
> >sel_update_enabled ||
> --
> 2.43.0

Reply via email to