On Thu, 19 Mar 2026, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > Rename skl_print_plane_changes() to skl_print_plane_wm_changes() > to better reflect what it does.
Could also go for skl_wm_* naming, but *shrug* for static functions. Reviewed-by: Jani Nikula <[email protected]> > > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/display/skl_watermark.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c > b/drivers/gpu/drm/i915/display/skl_watermark.c > index 8b1b371fbfab..6c8dab847ae2 100644 > --- a/drivers/gpu/drm/i915/display/skl_watermark.c > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c > @@ -2602,11 +2602,12 @@ static char enast(bool enable) > } > > static noinline_for_stack void > -skl_print_plane_changes(struct intel_display *display, > - struct intel_plane *plane, > - const struct skl_plane_wm *old_wm, > - const struct skl_plane_wm *new_wm) > +skl_print_plane_wm_changes(struct intel_plane *plane, > + const struct skl_plane_wm *old_wm, > + const struct skl_plane_wm *new_wm) > { > + struct intel_display *display = to_intel_display(plane); > + > drm_dbg_kms(display->drm, > "[PLANE:%d:%s] level > %cwm0,%cwm1,%cwm2,%cwm3,%cwm4,%cwm5,%cwm6,%cwm7,%ctwm,%cswm,%cstwm" > " -> > %cwm0,%cwm1,%cwm2,%cwm3,%cwm4,%cwm5,%cwm6,%cwm7,%ctwm,%cswm,%cstwm\n", > @@ -2738,7 +2739,7 @@ skl_print_wm_changes(struct intel_atomic_state *state) > if (skl_plane_wm_equals(display, old_wm, new_wm)) > continue; > > - skl_print_plane_changes(display, plane, old_wm, new_wm); > + skl_print_plane_wm_changes(plane, old_wm, new_wm); > } > } > } -- Jani Nikula, Intel
