> -----Original Message----- > From: Intel-xe <[email protected]> On Behalf Of Imre Deak > Sent: Monday, 1 June 2026 12.38 > To: [email protected]; [email protected] > Subject: [PATCH v2 10/22] drm/i915/dp_link_training: Check for pending > autoretrain explicitly > > Check explicitly for a pending autoretrain by matching seq_train_failures == > 1. > > This makes the actual condition clear, since at the point where the counter > is checked it is also below MAX_SEQ_TRAIN_FAILURES. > > This also prepares for replacing the counter with an enum in a follow-up > change. >
Reviewed-by: Mika Kahola <[email protected]> > Signed-off-by: Imre Deak <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index f03e05c730a25..cbac9a70e8d5b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -1305,7 +1305,7 @@ void intel_dp_stop_link_train(struct intel_dp *intel_dp, > > if (!display->hotplug.ignore_long_hpd && > link_training->seq_train_failures < MAX_SEQ_TRAIN_FAILURES) { > - int delay_ms = link_training->seq_train_failures ? 0 : 2000; > + int delay_ms = link_training->seq_train_failures == 1 ? 0 : > 2000; > > intel_encoder_link_check_queue_work(encoder, delay_ms); > } > @@ -2006,7 +2006,7 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp) > if (link_training->seq_train_failures >= MAX_SEQ_TRAIN_FAILURES) > return false; > > - if (link_training->seq_train_failures) > + if (link_training->seq_train_failures == 1) > return true; > > /* Retrain if link not ok */ > -- > 2.49.1
