On 02/06/2026 12:09, Jani Nikula wrote:
Having two small files for panic handling is a bit too much. Merge
i915_panic.c into i915_gem_panic.c. This is just code movement, cleanups
will follow.


Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <[email protected]>

Cc: Jocelyn Falempe <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>
---
  drivers/gpu/drm/i915/Makefile             |  3 +-
  drivers/gpu/drm/i915/gem/i915_gem_panic.c | 33 ++++++++++++++++++---
  drivers/gpu/drm/i915/gem/i915_gem_panic.h |  9 +-----
  drivers/gpu/drm/i915/i915_driver.c        |  2 +-
  drivers/gpu/drm/i915/i915_panic.c         | 35 -----------------------
  drivers/gpu/drm/i915/i915_panic.h         |  9 ------
  6 files changed, 32 insertions(+), 59 deletions(-)
  delete mode 100644 drivers/gpu/drm/i915/i915_panic.c
  delete mode 100644 drivers/gpu/drm/i915/i915_panic.h

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 091b6647c383..1fd7a1a5f315 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -83,8 +83,7 @@ i915-y += \
        i915_fb_pin.o \
        i915_hdcp_gsc.o \
        i915_initial_plane.o \
-       i915_overlay.o \
-       i915_panic.o
+       i915_overlay.o
# "Graphics Technology" (aka we talk to the gpu)
  gt-y += \
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_panic.c 
b/drivers/gpu/drm/i915/gem/i915_gem_panic.c
index 7407c5668c71..14ea45dcdd8f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_panic.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_panic.c
@@ -3,6 +3,7 @@
#include <drm/drm_cache.h>
  #include <drm/drm_panic.h>
+#include <drm/intel/display_parent_interface.h>
#include "display/intel_fb.h"
  #include "display/intel_display_types.h"
@@ -83,7 +84,7 @@ static void i915_gem_object_panic_page_set_pixel(struct 
drm_scanout_buffer *sb,
        }
  }
-struct intel_panic *i915_gem_object_alloc_panic(void)
+static struct intel_panic *i915_gem_object_alloc_panic(void)
  {
        struct intel_panic *panic;
@@ -97,8 +98,8 @@ struct intel_panic *i915_gem_object_alloc_panic(void)
   * Use current vaddr if it exists, or setup a list of pages.
   * pfn is not supported yet.
   */
-int i915_gem_object_panic_setup(struct intel_panic *panic, struct 
drm_scanout_buffer *sb,
-                               struct drm_gem_object *_obj, bool panic_tiling)
+static int i915_gem_object_panic_setup(struct intel_panic *panic, struct 
drm_scanout_buffer *sb,
+                                      struct drm_gem_object *_obj, bool 
panic_tiling)
  {
        enum i915_map_type has_type;
        struct drm_i915_gem_object *obj = to_intel_bo(_obj);
@@ -126,10 +127,34 @@ int i915_gem_object_panic_setup(struct intel_panic 
*panic, struct drm_scanout_bu
        return -EOPNOTSUPP;
  }
-void i915_gem_object_panic_finish(struct intel_panic *panic)
+static void i915_gem_object_panic_finish(struct intel_panic *panic)
  {
        i915_panic_kunmap(panic);
        panic->page = -1;
        kfree(panic->pages);
        panic->pages = NULL;
  }
+
+static struct intel_panic *intel_panic_alloc(void)
+{
+       return i915_gem_object_alloc_panic();
+}
+
+static int intel_panic_setup(struct intel_panic *panic, struct 
drm_scanout_buffer *sb)
+{
+       struct intel_framebuffer *fb = sb->private;
+       struct drm_gem_object *obj = intel_fb_bo(&fb->base);
+
+       return i915_gem_object_panic_setup(panic, sb, obj, fb->panic_tiling);
+}
+
+static void intel_panic_finish(struct intel_panic *panic)
+{
+       return i915_gem_object_panic_finish(panic);
+}
+
+const struct intel_display_panic_interface i915_display_panic_interface = {
+       .alloc = intel_panic_alloc,
+       .setup = intel_panic_setup,
+       .finish = intel_panic_finish,
+};
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_panic.h 
b/drivers/gpu/drm/i915/gem/i915_gem_panic.h
index 91ab6722d37c..82c3aca6f1f3 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_panic.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_panic.h
@@ -6,13 +6,6 @@
#include <linux/types.h> -struct drm_gem_object;
-struct drm_scanout_buffer;
-struct intel_panic;
-
-struct intel_panic *i915_gem_object_alloc_panic(void);
-int i915_gem_object_panic_setup(struct intel_panic *panic, struct 
drm_scanout_buffer *sb,
-                               struct drm_gem_object *_obj, bool panic_tiling);
-void i915_gem_object_panic_finish(struct intel_panic *panic);
+extern const struct intel_display_panic_interface i915_display_panic_interface;
#endif /* __I915_GEM_PANIC_H__ */
diff --git a/drivers/gpu/drm/i915/i915_driver.c 
b/drivers/gpu/drm/i915/i915_driver.c
index 60d5e06675ab..8294899a52d4 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -80,6 +80,7 @@
  #include "gem/i915_gem_ioctls.h"
  #include "gem/i915_gem_mman.h"
  #include "gem/i915_gem_object_frontbuffer.h"
+#include "gem/i915_gem_panic.h"
  #include "gem/i915_gem_pm.h"
  #include "gt/intel_gt.h"
  #include "gt/intel_gt_pm.h"
@@ -112,7 +113,6 @@
  #include "i915_irq.h"
  #include "i915_memcpy.h"
  #include "i915_overlay.h"
-#include "i915_panic.h"
  #include "i915_perf.h"
  #include "i915_query.h"
  #include "i915_reg.h"
diff --git a/drivers/gpu/drm/i915/i915_panic.c 
b/drivers/gpu/drm/i915/i915_panic.c
deleted file mode 100644
index 412db72797d8..000000000000
--- a/drivers/gpu/drm/i915/i915_panic.c
+++ /dev/null
@@ -1,35 +0,0 @@
-// SPDX-License-Identifier: MIT
-/* Copyright © 2025 Intel Corporation */
-
-#include <drm/drm_panic.h>
-#include <drm/intel/display_parent_interface.h>
-
-#include "display/intel_display_types.h"
-#include "display/intel_fb.h"
-#include "gem/i915_gem_panic.h"
-
-#include "i915_panic.h"
-
-static struct intel_panic *intel_panic_alloc(void)
-{
-       return i915_gem_object_alloc_panic();
-}
-
-static int intel_panic_setup(struct intel_panic *panic, struct 
drm_scanout_buffer *sb)
-{
-       struct intel_framebuffer *fb = sb->private;
-       struct drm_gem_object *obj = intel_fb_bo(&fb->base);
-
-       return i915_gem_object_panic_setup(panic, sb, obj, fb->panic_tiling);
-}
-
-static void intel_panic_finish(struct intel_panic *panic)
-{
-       return i915_gem_object_panic_finish(panic);
-}
-
-const struct intel_display_panic_interface i915_display_panic_interface = {
-       .alloc = intel_panic_alloc,
-       .setup = intel_panic_setup,
-       .finish = intel_panic_finish,
-};
diff --git a/drivers/gpu/drm/i915/i915_panic.h 
b/drivers/gpu/drm/i915/i915_panic.h
deleted file mode 100644
index 743d8c861c42..000000000000
--- a/drivers/gpu/drm/i915/i915_panic.h
+++ /dev/null
@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/* Copyright © 2025 Intel Corporation */
-
-#ifndef __I915_PANIC_H__
-#define __I915_PANIC_H__
-
-extern const struct intel_display_panic_interface i915_display_panic_interface;
-
-#endif /* __I915_PANIC_H__ */

Reply via email to