On Mon, 08 Jun 2026, "Borah, Chaitanya Kumar" <[email protected]> wrote: > On 6/3/2026 8:44 PM, Jani Nikula wrote: >> While reviewing some patches I noticed the >> xelpd_program_plane_pre_csc_lut() and xelpd_program_plane_post_csc_lut() >> functions were a bit convoluted. Reduce the number of loops in each from >> four to one, among other things. > > > Other than the nit in patch 7, LGTM. > > Reviewed-by: Chaitanya Kumar Borah <[email protected]>
Thanks for the review, pushed to din, fixed the whitespace while applying. BR, Jani. > >> >> BR, >> Jani. >> >> >> Jani Nikula (8): >> drm/i915/color: clean up variables in >> xelpd_program_plane_pre_csc_lut() >> drm/i915/color: clean up variables in >> xelpd_program_plane_post_csc_lut() >> drm/i915/color: reduce indent in xelpd_program_plane_pre_csc_lut() >> drm/i915/color: reduce indent in xelpd_program_plane_post_csc_lut() >> drm/i915/color: join loops in xelpd_program_plane_pre_csc_lut() >> drm/i915/color: join loops in xelpd_program_plane_post_csc_lut() >> drm/i915/color: deduplicate loops in xelpd_program_plane_pre_csc_lut() >> drm/i915/color: deduplicate loops in >> xelpd_program_plane_post_csc_lut() >> >> drivers/gpu/drm/i915/display/intel_color.c | 117 ++++++++------------- >> 1 file changed, 45 insertions(+), 72 deletions(-) >> > -- Jani Nikula, Intel
