On Wed, Jun 10, 2026 at 01:12:08AM +0200, Michał Grzelak wrote:
> Apparently during review of commit 17d70a0760f2 ("drm/i915/casf: Extract
> scaler_has_casf()") I missed that argument plane_state isn't used
> anymore. While at it couple other fixes included.
>
> This series will almost surely need a better splitting than currently
> is, but I hope now it is slightly easier to review.
>
> BR,
> Michał
>
>
> Michał Grzelak (9):
> drm/i915/scaler: remove unused plane_state argument
> drm/i915/scaler: s/i/scaler_id/
Those seem fine.
> drm/i915/scaler: de-Morgan-ize !scaler_has_casf()
> drm/i915/scaler: move independent CASF check
> drm/i915/scaler: check CASF before allocation's loop
> drm/i915/scaler: inline CASF scaler allocation
> drm/i915/scaler: linearize scaler allocation
> drm/i915/scaler: move CASF alloc check into
> intel_atomic_setup_scaler()
> drm/i915/scaler: move CASF alloc check into setup_crtc_scaler()
This looks like it's replacing a simple "does this scale have CASF?"
check with some kind of more complicated special casing of the CASF
scaler elsewhere. I don't like it.
>
> drivers/gpu/drm/i915/display/skl_scaler.c | 43 ++++++++++++-----------
> 1 file changed, 22 insertions(+), 21 deletions(-)
>
> --
> 2.45.2
--
Ville Syrjälä
Intel
