On Tue, 09 Jun 2026, Jonathan Cavitt <[email protected]> wrote: > Refactor all error messages resulting from generic_handle_irq_safe() > failures in I915 for clarity.
This needs to be sent separately from the rest, and merged via drm-intel-next, while the rest should go through drm-xe-next. Reviewed-by: Jani Nikula <[email protected]> > > v2: > - Use drm_err_ratelimited() correctly (jcavitt) > > v3: > - Use xe_err_ratelimited() instead (Jadav) > - Split into patch series (jcavitt) > > v4: > - Use suggested phrasing (Wajdeczko) > > v5: > - s/PTR_ERR/ERR_PTR (jcavitt) > > Suggested-by: Raag Jadav <[email protected]> > Suggested-by: Michal Wajdeczko <[email protected]> > Signed-off-by: Jonathan Cavitt <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +- > drivers/gpu/drm/i915/gt/intel_gsc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c > b/drivers/gpu/drm/i915/display/intel_lpe_audio.c > index 022ad18044bf..ff2cf479d8e1 100644 > --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c > +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c > @@ -265,7 +265,7 @@ void intel_lpe_audio_irq_handler(struct intel_display > *display) > ret = generic_handle_irq_safe(display->audio.lpe.irq); > if (ret) > drm_err_ratelimited(display->drm, > - "error handling LPE audio irq: %d\n", ret); > + "LPE audio: irq handling failed (%pe)\n", > ERR_PTR(ret)); > } > > /** > diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c > b/drivers/gpu/drm/i915/gt/intel_gsc.c > index 050d909fb4f8..1c06bf76568a 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gsc.c > +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c > @@ -286,7 +286,7 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned > int intf_id) > > ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq); > if (ret) > - gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret); > + gt_err_ratelimited(gt, "GSC: irq handling failed (%pe)\n", > ERR_PTR(ret)); > } > > void intel_gsc_irq_handler(struct intel_gt *gt, u32 iir) -- Jani Nikula, Intel
