Hi, On Wed, Jul 22, 2026 at 04:08:45PM +0200, Krzysztof Niemiec wrote: > On 2026-07-22 at 12:29:18 +0200, Sebastian Brzezinka wrote: > > Replace the verbose MIT license boilerplate in the core driver > > init, PCI enumeration and module parameter files with the > > corresponding SPDX-License-Identifier tag. This preserves the > > existing copyright notices while removing duplicated legal text, per > > Documentation/process/license-rules.rst. > > > > No functional changes. > > > > Signed-off-by: Sebastian Brzezinka <[email protected]> > > --- > > drivers/gpu/drm/i915/i915_driver.c | 25 ++----------------------- > > drivers/gpu/drm/i915/i915_drv.h | 25 ++----------------------- > > drivers/gpu/drm/i915/i915_params.c | 21 +-------------------- > > drivers/gpu/drm/i915/i915_params.h | 21 +-------------------- > > drivers/gpu/drm/i915/i915_pci.c | 21 +-------------------- > > 5 files changed, 7 insertions(+), 106 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > b/drivers/gpu/drm/i915/i915_driver.c > > index ce6d20958320..3beeccbed949 100644 > > --- a/drivers/gpu/drm/i915/i915_driver.c > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > @@ -1,30 +1,9 @@ > > -/* i915_drv.c -- i830,i845,i855,i865,i915 driver -*- linux-c -*- > > - */ > > +// SPDX-License-Identifier: MIT > > /* > > + * i915_drv.c -- i830,i845,i855,i865,i915 driver -*- linux-c -*- > > * > > * Copyright 2003 Tungsten Graphics, Inc., Cedar Park, Texas. > > * All Rights Reserved. > > I'll ask cause I'm not sure - Can we put an SPDX identifier on this if > there's "All Rights Reserved" in the license? The original text of the > MIT license doesn't have it, so I *think* it would make it a derivative > license. Right now the phrase "All Rights Reserved" is vacuous because > all the members of the convention that requires the use of it are now > also all members of the convention saying that it's implicit; but strictly > technically speaking the text of the license on this file IS different > than original MIT. > > It's probably not that big of a deal and/or I'm not fully informed on > this (there's a bunch of files in the kernel, even new-ish ones, that do > "All Rights Reserved" with SPDX: MIT, so maybe this is allowed) - but I > think it's worth double checking.
I don't really know what "All Rights Reserved" means in this context, but this is out of the license itself. What the patch is doing is to replace the MIT license with the SPDX identifier and leave things as they are. What can be done is to add Intel as a copirighter, giving that also Intel has been contributing to this file. But it's not strictly necessary to the scope of this series. Andi
