Hi, This is v4 of the series to reduce the clock gating interface between the display code and core i915. The first three patches received Reviewed-by tags and have already been merged, so this version contains only the two remaining patches.
Sashiko pointed out that the original patch 4/5 dropped the HSW/BDW GT/uncore clock gating workarounds when replacing the call to intel_clock_gating_init() on PC8+ exit. Fix this by restoring the display/PCH registers directly in display code and restoring the GT/uncore workarounds through the display parent interface. Only the former patch 4/5 has been modified. The former patch 5/5 is unchanged apart from rebasing. Previous versions: https://patchwork.freedesktop.org/series/169493/ In v2: * Reworked the previous version so we have only one entry point, instead of an _early() and a _late() function. It turns out that this is not necessary because some platforms were using only _early() and the others were using _late() (not both); * Removed back-dependency from the display code into the core code by avoiding calls to intel_clock_gating_init() (Jani); In v3: * Added intel_display_clock_gating.o to xe's Makefile to prevent linking breakage; In v4: * Drop the three patches already merged. * Preserve HSW/BDW GT/uncore clock gating workarounds on PC8+ exit through the display parent interface (Sashiko). Please review. Cheers, Luca. Luca Coelho (2): drm/i915/display: add a way to restore only display/pch registers in clock_gating drm/i915/display: split part of intel_display_reset_finish() to a new function .../i915/display/intel_display_clock_gating.c | 7 ++++ .../i915/display/intel_display_clock_gating.h | 1 + .../drm/i915/display/intel_display_power.c | 7 +++- .../drm/i915/display/intel_display_reset.c | 19 +++++++--- .../drm/i915/display/intel_display_reset.h | 1 + drivers/gpu/drm/i915/display/intel_parent.c | 9 +++++ drivers/gpu/drm/i915/display/intel_parent.h | 3 ++ drivers/gpu/drm/i915/gt/intel_reset.c | 5 +++ drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/intel_clock_gating.c | 37 ++++++++++++++++--- drivers/gpu/drm/i915/intel_clock_gating.h | 2 + drivers/gpu/drm/xe/Makefile | 1 + include/drm/intel/display_parent_interface.h | 7 ++++ 13 files changed, 86 insertions(+), 14 deletions(-) -- 2.53.0
