On Mon, Aug 04, 2014 at 11:28:58AM -0300, Paulo Zanoni wrote: > 2014-08-04 11:15 GMT-03:00 Damien Lespiau <[email protected]>: > > We don't actually need to write the HDMI entry on DDIs that have no > > chance to be used as HDMI ports. > > > > While this patch shouldn't change the current behaviour, it makes > > further enabling work easier as we'll have an eDP table filling the full > > 10 entries. > > > > Suggested-by: Satheeshakrishna M <[email protected]> > > Signed-off-by: Damien Lespiau <[email protected]> > > While your patch looks correct, maybe you could have used > dev_priv->vbt.ddi_port_info[port].supports_{dvi,hdmi}, just like we > already do in intel_ddi_init. Or you could set another variable at > intel_ddi_init and use it, or do some other equivalent check that > doesn't require knowledge of what can really go in each port (since we > already have it at intel_ddi_init and we probably shouldn't duplicate > it to avoid future desync). > > Anyway, the patch looks correct for now. So if you still think the > current approach is the best, you can add Reviewed-by: Paulo Zanoni > <[email protected]>
I actually like that better, Daniel, hold on your horses :) -- Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
