On Thu, Sep 18, 2014 at 3:37 PM, Jani Nikula <[email protected]> wrote: > On Thu, 18 Sep 2014, Daniel Vetter <[email protected]> wrote: >> lgtm, but I think to make code extraction into new files really worth >> it this should be followed up with a small patch to add an overview >> DOC section and kerneldoc for the non-static functions. Plus pulling >> it all in at a neat place into our driver docs. > > Can do; the main point of the patch was to get feedback and decide > whether to do some cleanups on the code within intel_display.c or to > move it elsewhere first.
I'd move first, then clean up. Otherwise rebasing and polishing due to review is super-painful. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
