On Wed, Dec 03, 2014 at 05:33:24PM +0000, Damien Lespiau wrote: > When playing around with debugfs and a HSW machine I noticed that we > were displaying some garbled value in i915_ddb_info. This debugfs file > is only meaningful for gen9+, so don't display anything on earlier > platforms. > > Signed-off-by: Damien Lespiau <[email protected]> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c > b/drivers/gpu/drm/i915/i915_debugfs.c > index 6c16939..d0e445e 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2743,6 +2743,9 @@ static int i915_ddb_info(struct seq_file *m, void > *unused) > enum pipe pipe; > int plane; > > + if (INTEL_INFO(dev)->gen < 9) > + return 0;
-ENODEV or somesuch? But I guess we're not too consistent how we deal with such things, so seems OK as is too: Reviewed-by: Ville Syrjälä <[email protected]> > + > drm_modeset_lock_all(dev); > > ddb = &dev_priv->wm.skl_hw.ddb; > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
