On Mon, Jun 15, 2015 at 01:54:40PM +0200, Daniel Vetter wrote: > On Wed, Jun 03, 2015 at 03:45:08PM +0300, Mika Kahola wrote: > > From: Ville Syrjälä <[email protected]> > > > > Rather than reading out the current cdclk value use the cached value we > > have tucked away in dev_priv. > > > > v2: Rebased to the latest > > v3: Rebased to the latest > > v4: Fix for patch style problems > > > > Signed-off-by: Ville Syrjälä <[email protected]> > > Signed-off-by: Mika Kahola <[email protected]> > > This patch needs to be extended to also cover the recently added > skl_max_scale. Tvrtko has recently written a patch to add some checks to > that code too, would be good to resurrect that too. Chandra can help with > any questions wrt the skl scaler code.
Not quite I'm afraid. The CDCLK used in skl_max_scale() has to be part of the atomic state, even bumping CDCLK if possible/needed. If you use the cached cdclk in skl_max_scale(), it won't do the right thing when CDCLK is off (ie cached frew is the fallback 24Mhz ref clock) and we try to do the first modeset before waking up the display. I filed a bug about it already to track it: https://bugs.freedesktop.org/show_bug.cgi?id=90874 -- Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
