On Wed, Jul 22, 2015 at 04:34:27AM +0000, Gharpure, Mayuresh S wrote: > Hi Nabendu, > > PFA. I came across this patch from Damien Lespiau which prevents the topmost > plane from being exposed to user space. > > Once this patch is merged, the following correction in i-g-t won't be > required as it takes care of exposing only four planes when > drmModeGetPlaneResources is called. > > Also, as fourth plane and cursor planes are mutually exclusive, the number of > planes exposed to user space should not be five, as it gives the impression > that, five planes can be enabled at once, which is not the case. > > So, in my opinion we can take the fix in kernel instead of changing i-g-t.
Hi The patch from Damien is just a temporary solution. We will eventually need to expose the topmost plane as an overlay plane with the DRM_PLANE_TYPE_CURSOR hint. So it might still be good to take that into consideration. Thanks Patrik > > Regards, > Mayuresh > > -----Original Message----- > From: Intel-gfx [mailto:[email protected]] On Behalf Of > Nabendu Maiti > Sent: Monday, July 20, 2015 3:14 PM > To: [email protected] > Cc: Wood, Thomas <[email protected]> > Subject: [Intel-gfx] [PATCH i-g-t v2 1/2] lib/igt_fb : Add more overlay plane > support for bxt > > Added more overlay plane support for BXT. > > Signed-off-by: Nabendu Maiti <[email protected]> > --- > lib/igt_kms.c | 1 + > lib/igt_kms.h | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 0bb16b4..781ffa5 100644 > --- a/lib/igt_kms.c > +++ b/lib/igt_kms.c > @@ -213,6 +213,7 @@ const char *kmstest_plane_name(enum igt_plane plane) > [IGT_PLANE_1] = "plane1", > [IGT_PLANE_2] = "plane2", > [IGT_PLANE_3] = "plane3", > + [IGT_PLANE_4] = "plane4", > [IGT_PLANE_CURSOR] = "cursor", > }; > > diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 09c08aa..14c8b28 100644 > --- a/lib/igt_kms.h > +++ b/lib/igt_kms.h > @@ -53,6 +53,7 @@ enum igt_plane { > IGT_PLANE_PRIMARY = IGT_PLANE_1, > IGT_PLANE_2, > IGT_PLANE_3, > + IGT_PLANE_4, > IGT_PLANE_CURSOR, > }; > > @@ -205,7 +206,7 @@ struct igt_pipe { > igt_display_t *display; > enum pipe pipe; > bool enabled; > -#define IGT_MAX_PLANES 4 > +#define IGT_MAX_PLANES 5 > int n_planes; > igt_plane_t planes[IGT_MAX_PLANES]; > uint64_t background; /* Background color MSB BGR 16bpc LSB */ > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
