On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst <[email protected]> wrote: > > Op 05-08-15 om 15:08 schreef Daniel Vetter: >> We want to make sure that no one tries to acquire more locks and >> states, and ww mutexes provide debug facilities for that. So use them. >> >> Cc: Rob Clark <[email protected]> >> Cc: Maarten Lankhorst <[email protected]> >> Signed-off-by: Daniel Vetter <[email protected]> >> --- >> drivers/gpu/drm/drm_atomic.c | 2 ++ >> 1 file changed, 2 insertions(+) > I like the idea, played with the thought myself, but I think it might need to > be slightly less strict for transitional drivers.
What would blow up? This should only be called fairly late in the transition when most of the atomic handling is correctly done. And i915 is probably the most extreme example of a conversion, so if it works out for us I think everyone else should be fine too. Generally drivers only started to do fancy stuff with get_*_state once converted to atomic to start exploiting it, not before the transition is completed. i915 is different since we have a lot of our own modeset code ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
