If we have accumulated hangcheck score before reaching engine idle, that score will remain and is transferred to the next set of batches. This is wrong as idle is a quite clear boundary to prevent hangcheck score manipulation across batches.
Fix this by clearing the score if engine reaches idle. Cc: Chris Wilson <[email protected]> Signed-off-by: Mika Kuoppala <[email protected]> --- drivers/gpu/drm/i915/i915_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 3507269..c1d1400 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -3091,6 +3091,9 @@ static void i915_hangcheck_elapsed(struct work_struct *work) ring->hangcheck.acthd = ring->hangcheck.max_acthd = 0; } + if (!busy) + ring->hangcheck.score = 0; + ring->hangcheck.seqno = seqno; ring->hangcheck.acthd = acthd; busy_count += busy; -- 2.5.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
