Sorry for my incorrect grammar on my patch. It should be following description
(mdelay-->msleep),
...
v2:
- straight up to loop execution for more clear in code readability
- mdelay will be replaced with msleep by Daniel's new patch
drm/i915: mdelay(10) considered harmful
...
Gary
-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Monday, December 21, 2015 7:52 PM
To: Chris Wilson <[email protected]>; Daniel Vetter <[email protected]>;
Wang, Gary C <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Correct max delay for HDMI
hotplug live status checking
On Mon, Dec 21, 2015 at 10:37:25AM +0000, Chris Wilson wrote:
> On Mon, Dec 21, 2015 at 11:29:16AM +0100, Daniel Vetter wrote:
> > On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote:
> > > The total delay of HDMI hotplug detecting with 30ms have already
> > > been split into a resolution of 3 retries of 10ms each, for the
> > > worst cases. But it still suffered from only waiting 10ms at most
> > > in intel_hdmi_detect(). This patch corrects it by reading hotplug
> > > status with 4 times at most for 30ms delay.
> > >
> > > v2:
> > > - straight up to loop execution for more clear in code readability
> > > - mdelay will replace with msleep by Daniel's new patch
> > >
> > > drm/i915: mdelay(10) considered harmful
> > >
> > > - suggest to re-evaluate try times for being compatible to old
> > > HDMI monitor
> > >
> > > Reviewed-by: Cooper Chiou <[email protected]>
> > > Tested-by: Gary Wang <[email protected]>
> > > Cc: Jani Nikula <[email protected]>
> > > Cc: Daniel Vetter <[email protected]>
> > > Cc: Gavin Hindman <[email protected]>
> > > Cc: Sonika Jindal <[email protected]>
> > > Cc: Shashank Sharma <[email protected]>
> > > Signed-off-by: Gary Wang <[email protected]>
> >
> > Queued for -next (including cc: fixes), thanks for the patch.
>
> Using mdelay() or fixed to use msleep()?
msleep patch was merged already, I just had to resolve the conflict.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
