Hi Matt,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20160105]
[cannot apply to v4.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:    
https://github.com/0day-ci/linux/commits/Matt-Roper/drm-i915-bxt-Don-t-save-restore-eDP-panel-power-during-suspend/20160106-094646
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s5-01061315 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/agp_backend.h:33,
                    from include/drm/drmP.h:35,
                    from drivers/gpu/drm/i915/i915_suspend.c:27:
   drivers/gpu/drm/i915/i915_suspend.c: In function 'i915_save_display':
   drivers/gpu/drm/i915/i915_suspend.c:52:33: warning: suggest parentheses 
around '&&' within '||' [-Wparentheses]
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
                                    ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/gpu/drm/i915/i915_suspend.c:52:9: note: in expansion of macro 'if'
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
            ^
   drivers/gpu/drm/i915/i915_suspend.c:52:33: warning: suggest parentheses 
around '&&' within '||' [-Wparentheses]
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
                                    ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> drivers/gpu/drm/i915/i915_suspend.c:52:9: note: in expansion of macro 'if'
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
            ^
   drivers/gpu/drm/i915/i915_suspend.c:52:33: warning: suggest parentheses 
around '&&' within '||' [-Wparentheses]
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
                                    ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> drivers/gpu/drm/i915/i915_suspend.c:52:9: note: in expansion of macro 'if'
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) 
{
            ^

vim +/if +52 drivers/gpu/drm/i915/i915_suspend.c

    21   * IN NO EVENT SHALL TUNGSTEN GRAPHICS AND/OR ITS SUPPLIERS BE LIABLE 
FOR
    22   * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF 
CONTRACT,
    23   * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
    24   * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
    25   */
    26  
  > 27  #include <drm/drmP.h>
    28  #include <drm/i915_drm.h>
    29  #include "intel_drv.h"
    30  #include "i915_reg.h"
    31  
    32  static void i915_save_display(struct drm_device *dev)
    33  {
    34          struct drm_i915_private *dev_priv = dev->dev_private;
    35  
    36          /* Display arbitration control */
    37          if (INTEL_INFO(dev)->gen <= 4)
    38                  dev_priv->regfile.saveDSPARB = I915_READ(DSPARB);
    39  
    40          /* LVDS state */
    41          if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
    42                  dev_priv->regfile.saveLVDS = I915_READ(PCH_LVDS);
    43          else if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && 
!IS_I830(dev))
    44                  dev_priv->regfile.saveLVDS = I915_READ(LVDS);
    45  
    46          /* Panel power sequencer */
    47          if (HAS_PCH_SPLIT(dev)) {
    48                  dev_priv->regfile.savePP_CONTROL = 
I915_READ(PCH_PP_CONTROL);
    49                  dev_priv->regfile.savePP_ON_DELAYS = 
I915_READ(PCH_PP_ON_DELAYS);
    50                  dev_priv->regfile.savePP_OFF_DELAYS = 
I915_READ(PCH_PP_OFF_DELAYS);
    51                  dev_priv->regfile.savePP_DIVISOR = 
I915_READ(PCH_PP_DIVISOR);
  > 52          } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || 
!IS_BROXTON(dev)) {
    53                  dev_priv->regfile.savePP_CONTROL = 
I915_READ(PP_CONTROL);
    54                  dev_priv->regfile.savePP_ON_DELAYS = 
I915_READ(PP_ON_DELAYS);
    55                  dev_priv->regfile.savePP_OFF_DELAYS = 
I915_READ(PP_OFF_DELAYS);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to