On Tue, Apr 19, 2016 at 08:00:10AM +0530, Kumar, Shobhit wrote: > On Monday 18 April 2016 09:47 PM, [email protected] wrote: > > From: Ville Syrjälä <[email protected]> > > > > The power cycle delay starts _after_ turning off the panel power. Do the > > msleep after frobbing the pmic panel power gpio. > > > > Also toss in a FIXME about optimizing away needless waits. > > > > Cc: Shobhit Kumar <[email protected]> > > Cc: Jani Nikula <[email protected]> > > Fixes: fc45e8219907 ("drm/i915: Use the CRC gpio for panel enable/disable") > > Signed-off-by: Ville Syrjälä <[email protected]> > > Reviewed-by: Shobhit Kumar <[email protected]>
Pushed to dinq. Thanks for the reviews. > > > --- > > drivers/gpu/drm/i915/intel_dsi.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c > > b/drivers/gpu/drm/i915/intel_dsi.c > > index 34328ddaaab5..2b22bb9bb86f 100644 > > --- a/drivers/gpu/drm/i915/intel_dsi.c > > +++ b/drivers/gpu/drm/i915/intel_dsi.c > > @@ -688,11 +688,16 @@ static void intel_dsi_post_disable(struct > > intel_encoder *encoder) > > drm_panel_unprepare(intel_dsi->panel); > > > > msleep(intel_dsi->panel_off_delay); > > - msleep(intel_dsi->panel_pwr_cycle_delay); > > > > /* Panel Disable over CRC PMIC */ > > if (intel_dsi->gpio_panel) > > gpiod_set_value_cansleep(intel_dsi->gpio_panel, 0); > > + > > + /* > > + * FIXME As we do with eDP, just make a note of the time here > > + * and perform the wait before the next panel power on. > > + */ > > + msleep(intel_dsi->panel_pwr_cycle_delay); > > } > > > > static bool intel_dsi_get_hw_state(struct intel_encoder *encoder, > > -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
