As we allow contexts without PPGTT to be created, we should check if
a context has a PPGTT before populating PDPs from it.

Signed-off-by: Zhi Wang <[email protected]>
---
 drivers/gpu/drm/i915/intel_lrc.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 397fe65..c8fbdfb 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2386,19 +2386,22 @@ populate_lr_context(struct intel_context *ctx,
        ASSIGN_CTX_REG(reg_state, CTX_PDP0_LDW, GEN8_RING_PDP_LDW(engine, 0),
                       0);
 
-       if (USES_FULL_48BIT_PPGTT(ppgtt->base.dev)) {
-               /* 64b PPGTT (48bit canonical)
-                * PDP0_DESCRIPTOR contains the base address to PML4 and
-                * other PDP Descriptors are ignored.
-                */
-               ASSIGN_CTX_PML4(ppgtt, reg_state);
-       } else {
-               /* 32b PPGTT
-                * PDP*_DESCRIPTOR contains the base address of space supported.
-                * With dynamic page allocation, PDPs may not be allocated at
-                * this point. Point the unallocated PDPs to the scratch page
-                */
-               execlists_update_context_pdps(ppgtt, reg_state);
+       if (ctx->ppgtt) {
+               if (USES_FULL_48BIT_PPGTT(ppgtt->base.dev)) {
+                       /* 64b PPGTT (48bit canonical)
+                        * PDP0_DESCRIPTOR contains the base address to PML4 and
+                        * other PDP Descriptors are ignored.
+                        */
+                       ASSIGN_CTX_PML4(ppgtt, reg_state);
+               } else {
+                       /* 32b PPGTT
+                        * PDP*_DESCRIPTOR contains the base address of space
+                        * supported. With dynamic page allocation, PDPs may
+                        * not be allocated at this point. Point the unallocated
+                        * PDPs to the scratch page
+                        */
+                       execlists_update_context_pdps(ppgtt, reg_state);
+               }
        }
 
        if (engine->id == RCS) {
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to