Chris Wilson <[email protected]> writes: > If we are waiting upon an external fence, from the pov of hangcheck the > engine is stuck on the last submitted seqno. Currently we give a small > increment to the hangcheck score in order to catch a stuck waiter / > driver. Now that we both have an independent wait hangcheck and may be > stuck waiting on an external fence, resetting the GPU has little effect > on that external fence. As we cannot advance by resetting, skip > incrementing the hangcheck score. > > Signed-off-by: Chris Wilson <[email protected]> > Cc: Mika Kuoppala <[email protected]>
Stamped this on the CI series... Reviewed-by: Mika Kuoppala <[email protected]> > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 238c1fb682bc..ad6b1459a1a9 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -3099,10 +3099,6 @@ static void i915_hangcheck_elapsed(struct work_struct > *work) > if (engine->hangcheck.seqno == seqno) { > if (i915_seqno_passed(seqno, submit)) { > engine->hangcheck.action = HANGCHECK_IDLE; > - if (busy) { > - /* Safeguard against driver failure */ > - engine->hangcheck.score += BUSY; > - } > } else { > /* We always increment the hangcheck score > * if the engine is busy and still processing > -- > 2.9.3 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
