It gets fragile to duplicate the code for updating HSW_AUD_CFG. The only
change should be that the hdmi pixel clock is also updated in
i915_audio_component_sync_audio_rate(), but it should not be any
different.

Cc: Libin Yang <libin.y...@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 29 +++--------------------------
 1 file changed, 3 insertions(+), 26 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c 
b/drivers/gpu/drm/i915/intel_audio.c
index aa9bb9318d70..c22574769380 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -631,11 +631,9 @@ static int i915_audio_component_sync_audio_rate(struct 
device *kdev,
        struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
        struct intel_encoder *intel_encoder;
        struct intel_crtc *crtc;
-       struct drm_display_mode *mode;
+       struct drm_display_mode *adjusted_mode;
        struct i915_audio_component *acomp = dev_priv->audio_component;
        enum pipe pipe = INVALID_PIPE;
-       u32 tmp;
-       int n;
        int err = 0;
 
        /* HSW, BDW, SKL, KBL need this fix */
@@ -666,33 +664,12 @@ static int i915_audio_component_sync_audio_rate(struct 
device *kdev,
 
        DRM_DEBUG_KMS("pipe %c connects port %c\n",
                                  pipe_name(pipe), port_name(port));
-       mode = &crtc->config->base.adjusted_mode;
+       adjusted_mode = &crtc->config->base.adjusted_mode;
 
        /* port must be valid now, otherwise the pipe will be invalid */
        acomp->aud_sample_rate[port] = rate;
 
-       /* 2. check whether to set the N/CTS/M manually or not */
-       if (!audio_rate_need_prog(crtc, mode)) {
-               tmp = I915_READ(HSW_AUD_CFG(pipe));
-               tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
-               I915_WRITE(HSW_AUD_CFG(pipe), tmp);
-               goto unlock;
-       }
-
-       n = audio_config_get_n(mode, rate);
-       if (n == 0) {
-               DRM_DEBUG_KMS("Using automatic mode for N value on port %c\n",
-                                         port_name(port));
-               tmp = I915_READ(HSW_AUD_CFG(pipe));
-               tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
-               I915_WRITE(HSW_AUD_CFG(pipe), tmp);
-               goto unlock;
-       }
-
-       /* 3. set the N/CTS/M */
-       tmp = I915_READ(HSW_AUD_CFG(pipe));
-       tmp = audio_config_setup_n_reg(n, tmp);
-       I915_WRITE(HSW_AUD_CFG(pipe), tmp);
+       hsw_audio_config_update(crtc, port, adjusted_mode);
 
  unlock:
        mutex_unlock(&dev_priv->av_mutex);
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to