> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Michal Schmidt
> Sent: Tuesday, October 10, 2023 2:25 AM
> To: [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; Radoslaw Tyl
> <[email protected]>; Brandeburg, Jesse <[email protected]>
> Subject: [Intel-wired-lan] [PATCH net-next 3/5] iavf: in iavf_down, don't
> queue watchdog_task if comms failed
>
> The reason for queueing watchdog_task is to have it process the
> aq_required flags that are being set here. If comms failed, there's
> nothing to do, so return early.
>
> Signed-off-by: Michal Schmidt <[email protected]>
Reviewed-by: Wojciech Drewek <[email protected]>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 03156ca523fe..0b808fa34801 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -1420,8 +1420,10 @@ void iavf_down(struct iavf_adapter *adapter)
> iavf_clear_fdir_filters(adapter);
> iavf_clear_adv_rss_conf(adapter);
>
> - if (!(adapter->flags & IAVF_FLAG_PF_COMMS_FAILED) &&
> - !(test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section))) {
> + if (adapter->flags & IAVF_FLAG_PF_COMMS_FAILED)
> + return;
> +
> + if (!test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section)) {
> /* cancel any current operation */
> adapter->current_op = VIRTCHNL_OP_UNKNOWN;
> /* Schedule operations to close down the HW. Don't wait
> --
> 2.41.0
>
> _______________________________________________
> Intel-wired-lan mailing list
> [email protected]
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
