> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Drewek, Wojciech > Sent: Tuesday, October 10, 2023 1:24 PM > To: mschmidt <[email protected]>; [email protected] > Cc: Radoslaw Tyl <[email protected]>; Nguyen, Anthony L > <[email protected]>; Brandeburg, Jesse > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH net-next 1/5] iavf: fix comments about > old bit locks > > > -----Original Message----- > > From: Intel-wired-lan <[email protected]> On Behalf > > Of Michal Schmidt > > Sent: Tuesday, October 10, 2023 2:25 AM > > To: [email protected] > > Cc: Nguyen, Anthony L <[email protected]>; Radoslaw Tyl > > <[email protected]>; Brandeburg, Jesse > > <[email protected]> > > Subject: [Intel-wired-lan] [PATCH net-next 1/5] iavf: fix comments > > about old bit locks > > > > Bit lock __IAVF_IN_CRITICAL_TASK does not exist anymore since commit > > 5ac49f3c2702 ("iavf: use mutexes for locking of critical sections"). > > Adjust the comments accordingly. > > > > Signed-off-by: Michal Schmidt <[email protected]> > > Thanks for your contribution, Michal! > Reviewed-by: Wojciech Drewek <[email protected]> > > > --- > > drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c > > b/drivers/net/ethernet/intel/iavf/iavf_main.c > > index 43c47c633162..98ecf5d5a2f2 100644 > > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > > @@ -1276,7 +1276,7 @@ static void iavf_configure(struct iavf_adapter > > *adapter) > > * iavf_up_complete - Finish the last steps of bringing up a connection > > * @adapter: board private structure > > * > > - * Expects to be called while holding the __IAVF_IN_CRITICAL_TASK bit lock. > > + * Expects to be called while holding crit_lock. > > **/ > > static void iavf_up_complete(struct iavf_adapter *adapter) { @@ > > -1400,7 +1400,7 @@ static void iavf_clear_adv_rss_conf(struct > > iavf_adapter *adapter) > > * iavf_down - Shutdown the connection processing > > * @adapter: board private structure > > * > > - * Expects to be called while holding the __IAVF_IN_CRITICAL_TASK bit lock. > > + * Expects to be called while holding crit_lock. > > **/ > > void iavf_down(struct iavf_adapter *adapter) { > > -- > > 2.41.0 > > > > _______________________________________________ > > Intel-wired-lan mailing list > > [email protected] > > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan > _______________________________________________ > Intel-wired-lan mailing list > [email protected] > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
