> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Jesse Brandeburg
> Sent: Monday, October 9, 2023 5:18 PM
> To: Dan Carpenter <[email protected]>; Jinjie Ruan
> <[email protected]>
> Cc: [email protected]; [email protected]; Eric
> Dumazet <[email protected]>; Nguyen, Anthony L
> <[email protected]>; Simon Horman <[email protected]>;
> [email protected]; Keller, Jacob E <[email protected]>; Jakub
> Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S.
> Miller <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 1/2] igb: Fix an end of loop 
> test
> 
> On 10/5/2023 6:57 AM, Dan Carpenter wrote:
> > When we exit a list_for_each_entry() without hitting a break
> > statement, the list iterator isn't NULL, it just point to an offset
> > off the list_head.  In that situation, it wouldn't be too surprising
> > for
> > entry->free to be true and we end up corrupting memory.
> >
> > The way to test for these is to just set a flag.
> >
> > Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry()
> > helper")
> > Signed-off-by: Dan Carpenter <[email protected]>
> 
> Reviewed-by: Jesse Brandeburg <[email protected]>
> 
> 
> _______________________________________________
> Intel-wired-lan mailing list
> [email protected]
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <[email protected]>


_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Reply via email to