> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Jesse Brandeburg > Sent: Monday, October 9, 2023 5:18 PM > To: Dan Carpenter <[email protected]>; Jinjie Ruan > <[email protected]> > Cc: [email protected]; [email protected]; Eric Dumazet > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Simon Horman <[email protected]>; Jakub > Kicinski <[email protected]>; Keller, Jacob E <[email protected]>; intel- > [email protected]; Paolo Abeni <[email protected]>; David S. > Miller <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop > test > in ixgbe_set_vf_macvlan() > > On 10/5/2023 6:58 AM, Dan Carpenter wrote: > > The list iterator in a list_for_each_entry() loop can never be NULL. > > If the loop exits without hitting a break then the iterator points to > > an offset off the list head and dereferencing it is an out of bounds > > access. > > > > Before we transitioned to using list_for_each_entry() loops, then it > > was possible for "entry" to be NULL and the comments mention this. I > > have updated the comments to match the new code. > > > > Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry() > > helper") > > Signed-off-by: Dan Carpenter <[email protected]> > > Reviewed-by: Jesse Brandeburg <[email protected]> > > > _______________________________________________ > Intel-wired-lan mailing list > [email protected] > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <[email protected]> _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
