> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Tuesday, January 23, 2024 4:22 PM > To: [email protected] > Cc: Keller, Jacob E <[email protected]>; [email protected]; > Kolacinski, Karol <[email protected]>; Nguyen, Anthony L > <[email protected]>; Brandeburg, Jesse <[email protected]> > Subject: [Intel-wired-lan] [PATCH v7 iwl-next 7/7] ice: stop destroying and > reinitalizing Tx tracker during reset > > From: Jacob Keller <[email protected]> > > The ice driver currently attempts to destroy and re-initialize the Tx > timestamp tracker during the reset flow. The release of the Tx tracker > only happened during CORE reset or GLOBAL reset. The ice_ptp_rebuild() > function always calls the ice_ptp_init_tx function which will allocate > a new tracker data structure, resulting in memory leaks during PF reset. > > Certainly the driver should not be allocating a new tracker without > removing the old tracker data, as this results in a memory leak. > Additionally, there's no reason to remove the tracker memory during a > reset. Remove this logic from the reset and rebuild flow. Instead of > releasing the Tx tracker, flush outstanding timestamps just before we > reset the PHY timestamp block in ice_ptp_cfg_phy_interrupt(). > > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Karol Kolacinski <[email protected]> > Reviewed-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_ptp.c | 33 +++++++++++++++--------- > 1 file changed, 21 insertions(+), 12 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
