> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Tuesday, January 23, 2024 4:22 PM > To: [email protected] > Cc: Keller, Jacob E <[email protected]>; [email protected]; > Kolacinski, Karol <[email protected]>; Nguyen, Anthony L > <[email protected]>; Brandeburg, Jesse <[email protected]> > Subject: [Intel-wired-lan] [PATCH v7 iwl-next 6/7] ice: factor out > ice_ptp_rebuild_owner() > > From: Jacob Keller <[email protected]> > > The ice_ptp_reset() function uses a goto to skip past clock owner > operations if performing a PF reset or if the device is not the clock > owner. This is a bit confusing. Factor this out into > ice_ptp_rebuild_owner() instead. > > The ice_ptp_reset() function is called by ice_rebuild() to restore PTP > functionality after a device reset. Follow the convention set by the > ice_main.c file and rename this function to ice_ptp_rebuild(), in the > same way that we have ice_prepare_for_reset() and > ice_ptp_prepare_for_reset(). > > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Karol Kolacinski <[email protected]> > Reviewed-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ptp.c | 62 ++++++++++++++--------- > drivers/net/ethernet/intel/ice/ice_ptp.h | 6 +-- > 3 files changed, 42 insertions(+), 28 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
