> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Arkadiusz Kubalewski > Sent: Wednesday, February 7, 2024 9:49 PM > To: [email protected] > Cc: Bagnucki, Igor <[email protected]>; Kubalewski, Arkadiusz > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: fix pin phase adjust > updates on PF reset > > Do not allow to set phase adjust value for a pin if PF reset is in > progress, this would cause confusing netlink extack errors as the firmware > cannot process the request properly during the reset time. > > Return (-EBUSY) and report extack error for the user who tries configure > pin phase adjust during the reset time. > > Test by looping execution of below steps until netlink error appears: > - perform PF reset > $ echo 1 > /sys/class/net/<ice PF>/device/reset > - change pin phase adjust value: > $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml \ > --do pin-set --json '{"id":0, "phase-adjust":1000}' > > Fixes: 90e1c90750d7 ("ice: dpll: implement phase related callbacks") > Reviewed-by: Igor Bagnucki <[email protected]> > Signed-off-by: Arkadiusz Kubalewski <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_dpll.c | 3 +++ > 1 file changed, 3 insertions(+) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
