> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Maciej Fijalkowski > Sent: Wednesday, March 6, 2024 10:01 PM > To: [email protected] > Cc: [email protected]; Fijalkowski, Maciej > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Karlsson, Magnus <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: avoid forward declarations > in i40e_nvm.c > > Move code around to get rid of forward declarations. No functional changes. > > After a plain code juggling, checkpatch reported: > total: 0 errors, 7 warnings, 12 checks, 1581 lines checked > > so while at it let's address old issues as well. Should we ever address the > remaining unnecessary forward declarations within > drivers/net/ethernet/intel/, consider this change as a starting > point/reference. > > As reported in [0], there would be a lot more of work to do...if we care. > > [0]: https://lore.kernel.org/intel-wired-lan/Zeh8qadiTGf413YU@boxer/T/#u > Signed-off-by: Maciej Fijalkowski <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_nvm.c | 1050 ++++++++++---------- > 1 file changed, 509 insertions(+), 541 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
