On Wed, Mar 06, 2024 at 05:30:54PM +0100, Maciej Fijalkowski wrote: > Move code around to get rid of forward declarations. No functional > changes. > > After a plain code juggling, checkpatch reported: > total: 0 errors, 7 warnings, 12 checks, 1581 lines checked > > so while at it let's address old issues as well. Should we ever address > the remaining unnecessary forward declarations within > drivers/net/ethernet/intel/, consider this change as a starting > point/reference. > > As reported in [0], there would be a lot more of work to do...if we > care. > > [0]: https://lore.kernel.org/intel-wired-lan/Zeh8qadiTGf413YU@boxer/T/#u > Signed-off-by: Maciej Fijalkowski <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_nvm.c | 1050 ++++++++++---------- > 1 file changed, 509 insertions(+), 541 deletions(-)
Thanks Maciej, FWIIW, it might have been easier to review if this had been broken up. But I appreciate that is a lot more work, and perhaps it wouldn't have been easier to review anyway. In any case, I did find time to work through this and I agree that the patch matches it's description. And is a positive step IMHO. Reviewed-by: Simon Horman <[email protected]>
