Hi Paul, On Apr 23 13:52, Paul Menzel wrote: > Dear Corinna, > > > Thank you for the patch. > > > Am 23.04.24 um 12:24 schrieb Corinna Vinschen: > > From: Paolo Abeni <[email protected]> > > It’d be great if you removed the trailing dot/period in the commit message > summary. > > > Sabrina reports that the igb driver does not cope well with large > > MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload > > corruption on TX. > > > > The root cause of the issue is that the driver does not take into > > account properly the (possibly large) shared info size when selecting > > the ring layout, and will try to fit two packets inside the same 4K > > page even when the 1st fraglist will trump over the 2nd head. > > > > Address the issue forcing the driver to fit a single packet per page, > > leaving there enough room to store the (currently) largest possible > > skb_shared_info. > > If you have a reproducer for this, it’d be great if you could document it in > the commit message.
I fixed the trailing dot and added a reproducer. Thanks, Corinna
