Hi Jiri, On Apr 23 13:26, Jiri Pirko wrote: > Tue, Apr 23, 2024 at 12:24:46PM CEST, [email protected] wrote: > >From: Paolo Abeni <[email protected]> > > > >Sabrina reports that the igb driver does not cope well with large > >MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload > >corruption on TX. > > > >The root cause of the issue is that the driver does not take into > >account properly the (possibly large) shared info size when selecting > >the ring layout, and will try to fit two packets inside the same 4K > >page even when the 1st fraglist will trump over the 2nd head. > > > >Address the issue forcing the driver to fit a single packet per page, > >leaving there enough room to store the (currently) largest possible > >skb_shared_info. > > > >Fixes: 3948b05950fd ("net: introduce a config option to tweak MAX_SKB_FRAG") > >Reported-by: Jan Tluka <[email protected]> > >Reported-by: Jirka Hladky <[email protected]> > >Reported-by: Sabrina Dubroca <[email protected]> > >Tested-by: Sabrina Dubroca <[email protected]> > >Tested-by: Corinna Vinschen <[email protected]> > >Signed-off-by: Paolo Abeni <[email protected]> > >--- > > drivers/net/ethernet/intel/igb/igb_main.c | 1 + > > Also, please use get_maintainer.pl script to get cclist.
done and done in v2 (for which I forgot the "in-reply-to" now, d'uh) Thanks, Corinna
