Re: [Intel-wired-lan] [PATCH iwl-next 04/12] idpf: avoid bloating &idpf_q_vector with big %NR_CPUS

[Jacob Keller]

On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
>  
>  struct idpf_rx_queue_stats {
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c 
> b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> index 3e8b24430dd8..a8be09a89943 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> @@ -69,7 +69,7 @@ static void idpf_deinit_vector_stack(struct idpf_adapter 
> *adapter)
>  static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)
>  {
>       clear_bit(IDPF_MB_INTR_MODE, adapter->flags);
> -     free_irq(adapter->msix_entries[0].vector, adapter);
> +     kfree(free_irq(adapter->msix_entries[0].vector, adapter));
>       queue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0)

I will say that this does not read very intuitively, but does make sense
when reading what free_irq does.